installimage version on Server (via NFS) is different #89

New issue

Closed

opened 2023-10-20 14:56:53 +02:00 by guettli · 3 comments

guettli commented

2023-10-20 14:56:53 +02:00

(Migrated from github.com)

Today we see that installimage behaves differently.

We guess that the script installimage has changed.

I attached the diff between the current master on Github and the code which is on the server (mounted on /root/.oldroot/nfs/install/):

installimage-diff.txt

It would be great, if we could see the latest version here on github, so that we can more easily see what has changed.

Please update the code here at Github.

Today we see that installimage behaves differently. We guess that the script `installimage` has changed. I attached the diff between the current master on Github and the code which is on the server (mounted on `/root/.oldroot/nfs/install/`): [installimage-diff.txt](https://github.com/hetzneronline/installimage/files/13054441/installimage-diff.txt) It would be great, if we could see the latest version here on github, so that we can more easily see what has changed. Please update the code here at Github.

👍 1

guettli commented

2023-10-20 16:30:23 +02:00

(Migrated from github.com)

Our image-name did no match, so it failed on these lines (which are not published here yet)

  if [[ "$IMG_ARCH" == 'unknown' ]]; then
    graph_error "ERROR: can not determine image arch from filename"
    return 1
  fi

Our image-name did no match, so it failed on these lines (which are not published here yet) ``` if [[ "$IMG_ARCH" == 'unknown' ]]; then graph_error "ERROR: can not determine image arch from filename" return 1 fi ```

👍 1

asciiprod commented

2023-10-24 09:41:08 +02:00

(Migrated from github.com)

We have added additional validation to prevent accidental installing arm64 images on x86 rescue systems:
https://github.com/hetzneronline/installimage/blob/master/functions.sh#L966

We have added additional validation to prevent accidental installing arm64 images on x86 rescue systems: https://github.com/hetzneronline/installimage/blob/master/functions.sh#L966

guettli commented

2023-10-24 13:19:59 +02:00

(Migrated from github.com)

thank you.