Minecraft/Folia
1
0
Fork 0
Code Issues 50 Pull requests 12 Projects Releases Packages Wiki Activity Actions

1.20 crash #89

New issue
Closed
opened 2023-06-10 10:57:58 +02:00 by MineSunshineone · 5 comments
MineSunshineone commented 2023-06-10 10:57:58 +02:00 (Migrated from github.com)
Copy link

Expected behavior

no crash

Observed/Actual behavior

https://pastes.dev/6oyl2sXTDO

Steps/models to reproduce

This problem occurs when I open a 1.19.4 archive and use TP

Plugin and Datapack List

plugins
[16:55:48 INFO]: Server Plugins (20):
[16:55:48 INFO]: Bukkit Plugins:
[16:55:48 INFO]: - AnCDK, ArmorStandEditor, Chunky, ColoredAnvils, CoreProtect, CreeperConfetti, DeathMessage, Essentials, EssentialsChat, FreedomChat
[16:55:48 INFO]: GSit, InvSeePlusPlus, Kaiivoid, LuckPerms, NoFlightInEnd, PistonMOTD, SkullPlugin, TAB, Vault, voicechat

Folia version

ver
[16:56:06 INFO]: Checking version, please wait...
[16:56:07 INFO]: This server is running Folia version git-Folia-"3fde784" (MC: 1.20) (Implementing API version 1.20-R0.1-SNAPSHOT) (Git: 3fde784 on dev/1.20)
Error obtaining version information
Previous version: git-Paper-4 (MC: 1.20)

Other

No response

### Expected behavior no crash ### Observed/Actual behavior https://pastes.dev/6oyl2sXTDO ### Steps/models to reproduce This problem occurs when I open a 1.19.4 archive and use TP ### Plugin and Datapack List > plugins [16:55:48 INFO]: Server Plugins (20): [16:55:48 INFO]: Bukkit Plugins: [16:55:48 INFO]: - AnCDK, ArmorStandEditor, Chunky, ColoredAnvils, CoreProtect, CreeperConfetti, DeathMessage, Essentials, EssentialsChat, FreedomChat [16:55:48 INFO]: GSit, InvSeePlusPlus, Kaiivoid, LuckPerms, NoFlightInEnd, PistonMOTD, SkullPlugin, TAB, Vault, voicechat ### Folia version > ver [16:56:06 INFO]: Checking version, please wait... [16:56:07 INFO]: This server is running Folia version git-Folia-"3fde784" (MC: 1.20) (Implementing API version 1.20-R0.1-SNAPSHOT) (Git: 3fde784 on dev/1.20) Error obtaining version information Previous version: git-Paper-4 (MC: 1.20) ### Other _No response_
jpenilla commented 2023-06-10 22:03:59 +02:00 (Migrated from github.com)
Copy link
diff --git a/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch b/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch
index 2ba6b8f..8096f4a 100644
--- a/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch
+++ b/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch
@@ -7,7 +7,7 @@ The returned TE may be in the world, in which case it is unsafe
 for the current thread to modify or access its contents.
 
 diff --git a/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java b/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java
-index 4a3ac7dedf5cb1e76f16ec4f18e82afc717d0ced..44609fb7965a03283e2bb50e483a8f60254de510 100644
+index 4a3ac7dedf5cb1e76f16ec4f18e82afc717d0ced..603f4fe0817be3d8a443f8b5213bc71a79f0e0ec 100644
 --- a/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java
 +++ b/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java
 @@ -84,6 +84,11 @@ public class ImposterProtoChunk extends ProtoChunk {
@@ -22,3 +22,12 @@ index 4a3ac7dedf5cb1e76f16ec4f18e82afc717d0ced..44609fb7965a03283e2bb50e483a8f60
          return this.wrapped.getBlockEntity(pos);
      }
  
+@@ -329,7 +334,7 @@ public class ImposterProtoChunk extends ProtoChunk {
+ 
+     @Override
+     public void initializeLightSources() {
+-        this.wrapped.initializeLightSources();
++        this.wrapped.skyLightSources.fillFrom(this); // Folia - block reading possibly in-world block data for worldgen threads
+     }
+ 
+     @Override

This should fix the issue, but it seems like maybe ChunkSkyLightSources usage didn't get removed properly when Starlight was ported? Removing that would also solve the issue.

```diff diff --git a/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch b/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch index 2ba6b8f..8096f4a 100644 --- a/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch +++ b/patches/server/0014-Block-reading-in-world-tile-entities-on-worldgen-thr.patch @@ -7,7 +7,7 @@ The returned TE may be in the world, in which case it is unsafe for the current thread to modify or access its contents. diff --git a/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java b/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java -index 4a3ac7dedf5cb1e76f16ec4f18e82afc717d0ced..44609fb7965a03283e2bb50e483a8f60254de510 100644 +index 4a3ac7dedf5cb1e76f16ec4f18e82afc717d0ced..603f4fe0817be3d8a443f8b5213bc71a79f0e0ec 100644 --- a/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java +++ b/src/main/java/net/minecraft/world/level/chunk/ImposterProtoChunk.java @@ -84,6 +84,11 @@ public class ImposterProtoChunk extends ProtoChunk { @@ -22,3 +22,12 @@ index 4a3ac7dedf5cb1e76f16ec4f18e82afc717d0ced..44609fb7965a03283e2bb50e483a8f60 return this.wrapped.getBlockEntity(pos); } +@@ -329,7 +334,7 @@ public class ImposterProtoChunk extends ProtoChunk { + + @Override + public void initializeLightSources() { +- this.wrapped.initializeLightSources(); ++ this.wrapped.skyLightSources.fillFrom(this); // Folia - block reading possibly in-world block data for worldgen threads + } + + @Override ``` This should fix the issue, but it seems like maybe ChunkSkyLightSources usage didn't get removed properly when Starlight was ported? Removing that would also solve the issue.
Spottedleaf commented 2023-06-10 23:11:51 +02:00 (Migrated from github.com)
Copy link

Fixed by github.com/PaperMC/Folia@9b2ffd03cf

Fixed by https://github.com/PaperMC/Folia/commit/9b2ffd03cfba3dddd8cd066816ef56cefa0dad22
MineSunshineone commented 2023-06-11 03:30:09 +02:00 (Migrated from github.com)
Copy link

still occur
[09:29:05 ERROR]: Thread Region Scheduler Thread #2 failed main thread check: Cannot remove entity off-main
java.lang.Throwable: null
at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.world.entity.Entity.setRemoved(Entity.java:5466) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.world.ChunkEntitySlices.unload(ChunkEntitySlices.java:122) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.chunk.system.scheduling.NewChunkHolder.unloadStage2(NewChunkHolder.java:850) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.processUnloads(ChunkHolderManager.java:1306) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.level.ChunkMap.processUnloads(ChunkMap.java:521) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.level.ChunkMap.tick(ChunkMap.java:509) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.level.ServerChunkCache.tick(ServerChunkCache.java:455) ~[?:?]
at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:793) ~[?:?]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1678) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:447) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1535) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
[09:29:05 ERROR]: [io.papermc.paper.threadedregions.TickRegionScheduler] Region #12 centered at chunk [1416, 1612] in world 'world' failed to tick:
net.minecraft.ReportedException: Exception ticking world
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1697) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:447) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1535) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.IllegalStateException: Cannot remove entity off-main
at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:79) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.world.entity.Entity.setRemoved(Entity.java:5466) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.world.ChunkEntitySlices.unload(ChunkEntitySlices.java:122) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.chunk.system.scheduling.NewChunkHolder.unloadStage2(NewChunkHolder.java:850) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.processUnloads(ChunkHolderManager.java:1306) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
at net.minecraft.server.level.ChunkTracker.processUnloads(ChunkTracker.java:521) ~[?:?]
at net.minecraft.server.level.ChunkTracker.tick(ChunkTracker.java:509) ~[?:?]
at net.minecraft.server.level.ServerChunkCache.tick(ServerChunkCache.java:455) ~[?:?]
at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:793) ~[?:?]
at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1678) ~[folia-1.20.jar:git-Folia-"9dcd6c2"]
... 6 more
[09:29:05 INFO]: [RegionShutdownThread] Awaiting scheduler termination for 60s
[09:29:05 INFO]: [RegionShutdownThread] Scheduler halted
[09:29:05 INFO]: Stopping server

still occur [09:29:05 ERROR]: Thread Region Scheduler Thread #2 failed main thread check: Cannot remove entity off-main java.lang.Throwable: null at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:78) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.world.entity.Entity.setRemoved(Entity.java:5466) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.world.ChunkEntitySlices.unload(ChunkEntitySlices.java:122) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.chunk.system.scheduling.NewChunkHolder.unloadStage2(NewChunkHolder.java:850) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.processUnloads(ChunkHolderManager.java:1306) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.level.ChunkMap.processUnloads(ChunkMap.java:521) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.level.ChunkMap.tick(ChunkMap.java:509) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.level.ServerChunkCache.tick(ServerChunkCache.java:455) ~[?:?] at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:793) ~[?:?] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1678) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:447) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1535) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at java.lang.Thread.run(Thread.java:833) ~[?:?] [09:29:05 ERROR]: [io.papermc.paper.threadedregions.TickRegionScheduler] Region #12 centered at chunk [1416, 1612] in world 'world' failed to tick: net.minecraft.ReportedException: Exception ticking world at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1697) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:447) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1535) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at java.lang.Thread.run(Thread.java:833) ~[?:?] Caused by: java.lang.IllegalStateException: Cannot remove entity off-main at io.papermc.paper.util.TickThread.ensureTickThread(TickThread.java:79) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.world.entity.Entity.setRemoved(Entity.java:5466) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.world.ChunkEntitySlices.unload(ChunkEntitySlices.java:122) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.chunk.system.scheduling.NewChunkHolder.unloadStage2(NewChunkHolder.java:850) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at io.papermc.paper.chunk.system.scheduling.ChunkHolderManager.processUnloads(ChunkHolderManager.java:1306) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] at net.minecraft.server.level.ChunkTracker.processUnloads(ChunkTracker.java:521) ~[?:?] at net.minecraft.server.level.ChunkTracker.tick(ChunkTracker.java:509) ~[?:?] at net.minecraft.server.level.ServerChunkCache.tick(ServerChunkCache.java:455) ~[?:?] at net.minecraft.server.level.ServerLevel.tick(ServerLevel.java:793) ~[?:?] at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1678) ~[folia-1.20.jar:git-Folia-"9dcd6c2"] ... 6 more [09:29:05 INFO]: [RegionShutdownThread] Awaiting scheduler termination for 60s [09:29:05 INFO]: [RegionShutdownThread] Scheduler halted [09:29:05 INFO]: Stopping server
electronicboy commented 2023-06-11 03:31:36 +02:00 (Migrated from github.com)
Copy link

That error is different to the one reported here.

That error is different to the one reported here.
MineSunshineone commented 2023-06-11 03:42:20 +02:00 (Migrated from github.com)
Copy link

i will create new issue thanks

i will create new issue thanks
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
ver/1.21.11
ver/1.21.8
ver/1.21.7
ver/1.21.6
ver/1.21.5
ver/1.21.4
dev/1.21.3
dev/1.21.1
ver/1.20.6
experiment/sectorfile
ver/1.20.4
ver/1.19.4
No results found.
Labels
Clear labels   
documentation
Improvements or additions to documentation

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
resolution: duplicate
Issue or Request is a copy of an existing ticket.

  
resolution: invalid
Issue or Request has no basis.

  
resolution: won't fix
Issue will not be resolved or feature not added.

  
status: needs triage

   
type: bug
Something doesn't work as it was intended to.

  
type: feature
Request for a new Feature.

  
type: performance

   
type: question
Issue represents a question and not a problem/request.

  
version: 1.19.4
Game version 1.19.4

  
version: 1.20
Game version 1.20

  
version: 1.20.1
Game version 1.20.1

  
version: 1.20.2
Game version 1.20.2

  
version: 1.20.4
Game version 1.20.4

  
version: 1.20.6
Game version 1.20.6

  
version: 1.21.11
Game version 1.21.11

  
version: 1.21.4
Game version 1.21.4

No labels
documentation
good first issue
help wanted
resolution: duplicate
resolution: invalid
resolution: won't fix
status: needs triage
type: bug
type: feature
type: performance
type: question
version: 1.19.4
version: 1.20
version: 1.20.1
version: 1.20.2
version: 1.20.4
version: 1.20.6
version: 1.21.11
version: 1.21.4
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Minecraft/Folia#89
No description provided.