Improve messages after upstream chunk api update #96

New issue

Open

opened 2023-06-18 17:27:43 +02:00 by masmc05 · 0 comments

masmc05 commented

2023-06-18 17:27:43 +02:00

(Migrated from github.com)

Yes, upstream removed the cached nms chunk from craftchunk, and every call to bukkit api chunks gets the chunk every time synchronously, which is redirected into a nms method which wasn't updated by folia, so it doesn't properly check for things and throw unsupported operation exceptions.

Describe the solution you'd like.

Update the used nms getChunk method or change the method to a newer one

Describe alternatives you've considered.

use proper isTickThread check (or maybe even better ensureTickThread)

Other

The people who used chunk object correctly and only from main thread shouldn't see a difference.

### Is your feature request related to a problem? Yes, upstream removed the cached nms chunk from craftchunk, and every call to bukkit api chunks gets the chunk every time synchronously, which is redirected into a nms method which wasn't updated by folia, so it doesn't properly check for things and throw unsupported operation exceptions. ![image](https://github.com/PaperMC/Folia/assets/63639746/e19f65f7-df0c-4e88-b3e1-7c1b3e411922) ![image](https://github.com/PaperMC/Folia/assets/63639746/3b1abe02-f4fb-4697-9d0e-e0159cd26388) ![image](https://github.com/PaperMC/Folia/assets/63639746/f464df0e-643d-4c33-b1cd-014896aa914a) ### Describe the solution you'd like. Update the used nms getChunk method or change the method to a newer one ### Describe alternatives you've considered. use proper isTickThread check (or maybe even better ensureTickThread) ### Other The people who used chunk object correctly and only from main thread shouldn't see a difference.