Added GlobalRegionScheduler#getExecutor and RegionScheduler#getExecutor #32

Closed

jdkeke142 wants to merge 2 commits from master into master

jdkeke142 commented

2023-04-03 05:03:22 +02:00

(Migrated from github.com)

I added GlobalRegionScheduler#getExecutor and RegionScheduler#getExecutor to get respectively an executor of the global region and to get an executor of a corresponding region at a location. I find that these methods were useful in regular paper when working with CompletableFuture, I think other developers too. This PR aims to reintroduce them

👍 2 🚀 2

Machine-Maker commented

2023-04-03 05:05:00 +02:00

(Migrated from github.com)

I think the method names should just be getExecutor(). They are on interfaces with the names Region and Global, it doesn't need to be repeated in the method name.

👍 1

kashike (Migrated from github.com) reviewed

2023-04-03 08:37:31 +02:00

jdkeke142 (Migrated from github.com) reviewed

2023-04-03 09:03:20 +02:00

kashike (Migrated from github.com) reviewed

2023-04-05 08:12:35 +02:00

jdkeke142 (Migrated from github.com) reviewed

2023-04-05 13:47:33 +02:00

Yomamaeatstoes (Migrated from github.com) reviewed

2023-05-10 21:55:12 +02:00

Yomamaeatstoes (Migrated from github.com) left a comment

Looks good

Spottedleaf commented

2023-05-14 01:01:57 +02:00

(Migrated from github.com)

I don't want to encourage usage of CompletableFuture, since they do not follow reasonable error handling. I've learned this the hard way from Mojang's code, and I don't expect plugins to do a better job.

😕 1 🚀 1