Fix Dialog command #420

Open

Dueris wants to merge 1 commit from CraftCanvasMC/fix/dialog-command into ver/1.21.11

Dueris commented

2025-12-27 01:42:40 +01:00

(Migrated from github.com)

The /dialog command is disabled in Folia, which this PR fixes. The command itself is relatively simple, and the entire dialog system is run on just packets(at least for the server side). The dialog system is only disabled, in Folia, from the command side. Plugins and signs can still execute dialog operations on Folia.

The dialog command only iterates over the target players, and sends a packet. The changes in this PR basically just schedule the sending of the packets to the target player scheduler, which while simple, fixes the dialog command functionality.

For testing purposes, I used the example dialog commands from the Minecraft Wiki:

/dialog show @a minecraft:server_links
/dialog show @a {type:"minecraft:notice",title:"Hello"}
/dialog show @a {type:"minecraft:confirmation",title:"Give yourself diamond?",yes:{label:"Yes please","action":{"type":"run_command","command":"give @s diamond"}},no:{label:"Nope"}}
/dialog clear @a

The `/dialog` command is disabled in Folia, which this PR fixes. The command itself is relatively simple, and the entire dialog system is run on just packets(at least for the server side). The dialog system is only disabled, in Folia, from the command side. Plugins and signs can still execute dialog operations on Folia. The dialog command only iterates over the target players, and sends a packet. The changes in this PR basically just schedule the sending of the packets to the target player scheduler, which while simple, fixes the dialog command functionality. For testing purposes, I used the example `dialog` commands from the [Minecraft Wiki](https://minecraft.wiki/w/Commands/dialog): ``` /dialog show @a minecraft:server_links /dialog show @a {type:"minecraft:notice",title:"Hello"} /dialog show @a {type:"minecraft:confirmation",title:"Give yourself diamond?",yes:{label:"Yes please","action":{"type":"run_command","command":"give @s diamond"}},no:{label:"Nope"}} /dialog clear @a ```

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin CraftCanvasMC/fix/dialog-command:CraftCanvasMC/fix/dialog-command

git switch CraftCanvasMC/fix/dialog-command

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch ver/1.21.11

git merge --no-ff CraftCanvasMC/fix/dialog-command

git switch CraftCanvasMC/fix/dialog-command

git rebase ver/1.21.11

git switch ver/1.21.11

git merge --ff-only CraftCanvasMC/fix/dialog-command

git switch CraftCanvasMC/fix/dialog-command

git rebase ver/1.21.11

git switch ver/1.21.11

git merge --no-ff CraftCanvasMC/fix/dialog-command

git switch ver/1.21.11

git merge --squash CraftCanvasMC/fix/dialog-command